ReadMe Review #1230
Merged
ReadMe Review #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
helenktsai
commented
Dec 2, 2023
•
helenktsai
commented
- Apply format template with link to component documentation
- Ensure no dead links
soujay
reviewed
Dec 15, 2023
soujay
reviewed
Dec 15, 2023
README.md
Outdated
| * RAVENDB_LICENSE: A RavenDB development license, expressed as JSON, but all on one line, with escaped quotes `\"` | ||
| * PASSPHRASE: Any phrase used to encrypt the connection information between steps in the CI | ||
| 1. RAVENDB_LICENSE: A RavenDB development license, expressed as JSON, but all on one line, with escaped quotes `\"` | ||
| 1. PASSPHRASE: Any phrase used to encrypt the connection information between steps in the CI |
There was a problem hiding this comment.
Any phrase used to encrypt the connection information between steps in the CI
- How do we do this in our current ci.yml?
There was a problem hiding this comment.
Good catch, looks like it's obsolete, I'll remove it.
Co-authored-by: Jayanthi <[email protected]>
soujay
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.